Re: Small code Suggestion

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Small code Suggestion

Jörg Schaible-2
Hi Ben,

Ben Blamey wrote:

> Hi,
>
> Cracking library folks! I have a tiny code suggestion:
>
> In the class: com.thoughtworks.xstream.io.xml.AbstractXppDriver I noticed
> that exceptions are being caught without the inner exception being set,
> i.e.:
>
>         try { ... } catch (XmlPullParserException e) {
>             throw new StreamException("Cannot create XmlPullParser");
>         }
>
> Rather than:
>
>         try { ... } catch (XmlPullParserException e) {
>             throw new StreamException("Cannot create XmlPullParser", e);
>         }
>
> I don't know about everyone else, but I find inner exceptions very useful
> when debugging. There are 3 exceptions thrown in that class that discard
> the information from the underlying cause. I haven't poked around
> elsewhere.

Can you open a JIRA issue please?

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email